Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable sanity.functional and dev.external on machines with criu318 #175

Closed
wants to merge 1 commit into from

Conversation

llxia
Copy link

@llxia llxia commented Aug 31, 2023

related: runtimes/backlog/issues/1099

@github-actions
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@llxia
Copy link
Author

llxia commented Aug 31, 2023

@AdamBrousseau could you review the PR? Thanks

@llxia llxia marked this pull request as ready for review August 31, 2023 20:08
Copy link

@AdamBrousseau AdamBrousseau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lftm but I don't believe we currently run these ppc criu specs by default in any build. We'll have to make another change in jdk11u.groovy and jdk17u.groovy if we want to turn them on as well as in the job generator I believe.

@llxia
Copy link
Author

llxia commented Sep 6, 2023

I noticed jdk11u-linux-ppc64le-openj9-criu and jdk17u-linux-ppc64le-openj9-criu. Can we use them? If jdk11u.groovy and jdk17u.groovy needs to be updated, could you help? Thanks

@llxia
Copy link
Author

llxia commented Sep 13, 2023

We should not block the change related to the test builds because jdk11u.groovy and jdk17u.groovy are not ready. If jdk11u.groovy and jdk17u.groovy needs to be updated, we can create separate PR.

Copy link

@AdamBrousseau AdamBrousseau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be updated. All machines are at 3.18 now so we don't need to add the extra label.

@AdamBrousseau
Copy link

As discussed, we can move the dev.external additional target to the regular IBM (CE) plinux specs.

@llxia
Copy link
Author

llxia commented Sep 20, 2023

This PR is no longer needed as CRIU is enabled as default on plinux and we do not need criu318 label anymore.

@llxia llxia closed this Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants