-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable sanity.functional and dev.external on machines with criu318 #175
Conversation
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
@AdamBrousseau could you review the PR? Thanks |
Signed-off-by: Lan Xia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lftm but I don't believe we currently run these ppc criu specs by default in any build. We'll have to make another change in jdk11u.groovy and jdk17u.groovy if we want to turn them on as well as in the job generator I believe.
I noticed jdk11u-linux-ppc64le-openj9-criu and jdk17u-linux-ppc64le-openj9-criu. Can we use them? If jdk11u.groovy and jdk17u.groovy needs to be updated, could you help? Thanks |
We should not block the change related to the test builds because jdk11u.groovy and jdk17u.groovy are not ready. If jdk11u.groovy and jdk17u.groovy needs to be updated, we can create separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be updated. All machines are at 3.18 now so we don't need to add the extra label.
As discussed, we can move the |
This PR is no longer needed as CRIU is enabled as default on plinux and we do not need criu318 label anymore. |
related: runtimes/backlog/issues/1099