Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded criu configs #183

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Remove unneeded criu configs #183

merged 1 commit into from
Oct 3, 2023

Conversation

mahdipub
Copy link

Now that CRIU is enabled by default on platforms for all versions that support it we can remove configs. Resolves issue#8372

@github-actions
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

Copy link

@AdamBrousseau AdamBrousseau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the *CRIU specs completely.
There are also a few places in openjdk_build_pipeline we can cleanup.

@mahdipub
Copy link
Author

mahdipub commented Oct 3, 2023

We can remove the *CRIU specs completely. There are also a few places in openjdk_build_pipeline we can cleanup.

@AdamBrousseau Sorry for delay, that's done.

Now that CRIU is enabled by default on platforms for all versions that support it we can remove configs. Resolves issue#8372

Signed-off-by: Mahdi Ardekanian <[email protected]>
@AdamBrousseau AdamBrousseau merged commit 9a41526 into ibmruntimes:ibm Oct 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants