Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduled Jobs #20

Open
sandrich opened this issue Jun 16, 2017 · 7 comments
Open

Scheduled Jobs #20

sandrich opened this issue Jun 16, 2017 · 7 comments

Comments

@sandrich
Copy link

Fantastic work. Just what I need. Thanks for that.

One idea. Instead of continuously running the containers could this also be done with ScheduledJob?

@ibotty
Copy link
Owner

ibotty commented Jun 16, 2017

Yes ScheduledJob is the right way to replace cron, and Job might be the right way to decouple the controller from the requesting of certificates. Unfortunately ScheduledJobs are only supported starting with origin 1.5, I don't know when 1.3 and 1.4 get out of support. AFAIR 1.3 does not even support Jobs.

Having said that, I am very willing to discuss a Job-based future of this project. My basic idea was that the route-certificate controller (now the watcher container's part that gets the routes) only schedules jobs that get one certificate. There would be a scheduled job that checks old certificates and schedules said jobs when necessary. I wonder whether combining requesting many certificate in one container (as is done now) is worth it or not. If needing that, it will further complicate the code.

Does anyone have any other ideas, comments?

@caruccio
Copy link

caruccio commented Jun 16, 2017 via email

@ibotty
Copy link
Owner

ibotty commented Jun 16, 2017

Oh, I misremembered. Fortunately the differences between CronJob and ScheduledJob won't matter much (only the openshift-letsencrypt template would be have to change, not the code to manage jobs).

@caruccio Can you tell me whether jobs work with origin 1.3? If so, we could go ahead with above plan starting now.

@caruccio
Copy link

caruccio commented Jun 16, 2017 via email

@ibotty
Copy link
Owner

ibotty commented Jun 16, 2017 via email

@caruccio
Copy link

caruccio commented Jun 16, 2017 via email

@ibotty
Copy link
Owner

ibotty commented Jun 16, 2017

Huh? That did not work for me. See openshift/origin#8622. Maybe I am missing something, but my testing did confirm that they would not be supported until they are stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants