Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for DelegationIdentity #5

Open
zhangwei983 opened this issue Aug 16, 2023 · 6 comments
Open

Support for DelegationIdentity #5

zhangwei983 opened this issue Aug 16, 2023 · 6 comments

Comments

@zhangwei983
Copy link

Just checked the identities at https://github.com/ic4j/ic4j-agent/tree/master/src/main/java/org/ic4j/agent/identity and found there's no DelegationIdentity like the one (https://github.com/BoomDAO/ICP.NET/blob/main/src/Agent/Identities/DelegationIdentity.cs) that ICP.NET(which is a C# agent for the IC) has. Any plans?

@rdobrik
Copy link
Contributor

rdobrik commented Aug 16, 2023

Thanks for your suggestion. Let me check C# code, we can implement it in Java as well.

@zhangwei983
Copy link
Author

Just want to check if there is an estimated time for this feature. Thanks

@rdobrik
Copy link
Contributor

rdobrik commented Sep 4, 2023

Sorry for late response, I was traveling last week and did not have my computer with me. Yes, I looked at C# implementation, delegation is a very useful feature to have. It might be a bit more complex I originally thought, I need to better understand all potential use cases.
Currently we are working on Websockets implementation, finishing sometimes this month. Meanwhile I will do some deep dive into Delegation mechanism, so we can start development early October.
If you have a time, I would like to have a quick chat with you, to better understand how do you plan to use it and if you have already some test case canisters I can use.

@vincent-dfinity
Copy link

vincent-dfinity commented Sep 21, 2023

Thank you for getting back to me. We're trying to support Internet Identity from Unity mobile games. Here is the basic workflow https://github.com/dfinity/examples/tree/master/native-apps/unity_ii_applink#workflow.
So we

  1. open the web browser from the game to access the dapp frontend
  2. Login with II and return the delegation
  3. Composite the DelegationIdentity to call the backend canister
    Here is how DelegationIdentity is constructed at C# side.

You can refer to the sample tutorial https://internetcomputer.org/docs/current/samples/native-app-integration as well.
Next, we want to support Android native apps as well, your Java agent is exactly the same thing as ICP.NET that we used for Unity. So if you guys can provide the DelegationIdentity, we can add the similar example as well. Thanks.

@rdobrik
Copy link
Contributor

rdobrik commented Sep 26, 2023

Hi Vincent, thanks. I also contacted Ethan from C#/Unity project so he can help me to provide more details about it. I will try to wrap up Websockets Java implementation this week, so I can start working on DelegationIdentity early October. Also need to apply for another Dfinity grant, I have several open Java ICP related project, but man has to eat too! :-)

@vincent-dfinity
Copy link

Hi Vincent, thanks. I also contacted Ethan from C#/Unity project so he can help me to provide more details about it. I will try to wrap up Websockets Java implementation this week, so I can start working on DelegationIdentity early October. Also need to apply for another Dfinity grant, I have several open Java ICP related project, but man has to eat too! :-)

Sure, please submit a grant application. If you have done that, could you please let me know the grant id that I can follow up? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants