Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add representative image to an Instrument #265

Open
agbeltran opened this issue Jan 20, 2022 · 4 comments
Open

Add representative image to an Instrument #265

agbeltran opened this issue Jan 20, 2022 · 4 comments
Labels
enhancement schema this involves changes to the ICAT schema

Comments

@agbeltran
Copy link
Member

Similar to #241, it would be useful to have a representative image associated with an Instrument to be able to display them in the associated UIs.

@agbeltran agbeltran added schema this involves changes to the ICAT schema enhancement labels Jan 20, 2022
@kevinphippsstfc
Copy link
Contributor

A simple fix for this, not requiring images to be stored in ICAT or perhaps a new ICAT component, would be to add an imageUrl field to Instrument. There is already a url field for a web page about the instrument.

@RKrahl
Copy link
Member

RKrahl commented Jan 20, 2022

I like the imageUrl idea. It could be used in any web user interface right away, without even the need to add any code to retrieve and display the image.

@agbeltran
Copy link
Member Author

yes, agreed, it would be great to have imageUrl

@agbeltran
Copy link
Member Author

Discussions in the ICAT collaboration meeting today raised a few interesting points:

  • instruments usually don't change and could be considered fairly static
  • a single image may not be enough for an instrument, and we might need multiple images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement schema this involves changes to the ICAT schema
Projects
None yet
Development

No branches or pull requests

3 participants