[bug] File not rotating when using a generator function

[JosuerBague]

Hey there,
I'm trying to use you package for my pino logger like so:

import { Logger as PinoLogger } from './logger.package';
const rfsa = require('rotating-file-stream');

const pad = (num: number) => (num > 9 ? ""  : "0") + num;

const generator = () => {
    const time = new Date();

    const year = time.getFullYear();
    const month = pad(time.getMonth() + 1);
    const day = pad(time.getDate());
    const hour = pad(time.getHours());

    return `application-${year}-${month}-${day}-${hour}.log`;
}

const stream = rfsa.createStream(generator, {
    interval: '15s',
    compress: true,
    path: 'logs'
})

const logger = new PinoLogger(stream);

export { logger };
export type { ILogger } from './libs/interfaces/interfaces';

This doesn't rotate the file. But when I provide a filename directly like so, it does:

const stream = rfsa.createStrearm('sample.log', { interval: '15s', compress: true, path: 'logs' })

[iccicci]

Your filename generator doesn't accepts parameters...

Please refer to the documentation.

If this solves the problem, feel free to close the issue.

[JosuerBague]

I tried using the filename generator in the documentation but it still wouldn't rotate the file.
Had it set to rotate at 10s.

const generator = (time: Date, index: number) => {
    if (!time) return "file.log";
  
    const month = time.getFullYear() + "" + pad(time.getMonth() + 1);
    const day = pad(time.getDate());
    const hour = pad(time.getHours());
    const minute = pad(time.getMinutes());
  
    return `${month}/${month}${day}-${hour}${minute}-${index}-file.log`;
  };



const stream = rfsa.createStream(generator, {
    interval: '10s',
    compress: true,
})

[iccicci]

I suggest you to follow error and warning events.

stream.on("error", console.log);
stream.on("warning", console.log);

More than this there some known problems when rfs.createStream is called twice with the same configuration; I suggest you to ensure that piece of code runs only once.

[nodermann2]

Hey there, I'm trying to use you package for my pino logger like so:

import { Logger as PinoLogger } from './logger.package';
const rfsa = require('rotating-file-stream');

const pad = (num: number) => (num > 9 ? ""  : "0") + num;

const generator = () => {
    const time = new Date();

    const year = time.getFullYear();
    const month = pad(time.getMonth() + 1);
    const day = pad(time.getDate());
    const hour = pad(time.getHours());

    return `application-${year}-${month}-${day}-${hour}.log`;
}

const stream = rfsa.createStream(generator, {
    interval: '15s',
    compress: true,
    path: 'logs'
})

const logger = new PinoLogger(stream);

export { logger };
export type { ILogger } from './libs/interfaces/interfaces';

This doesn't rotate the file. But when I provide a filename directly like so, it does:

const stream = rfsa.createStrearm('sample.log', { interval: '15s', compress: true, path: 'logs' })

The same problem, try to remove compress option.

[iccicci]

Hi @nodermann ,

Also your filename generator doesn't accepts parameters...

It must accept two parameters. Please refer to the documentation.

[iccicci]

Also compress: true probably works only on Linux, if you are using other operating systems... butter to use compress: "gzip".