Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icecc-scheduler bug when retry attempt at maximum limit #604

Open
hese10 opened this issue Jul 6, 2022 · 0 comments
Open

icecc-scheduler bug when retry attempt at maximum limit #604

hese10 opened this issue Jul 6, 2022 · 0 comments

Comments

@hese10
Copy link

hese10 commented Jul 6, 2022

When icecc-scheduler retries for "failed to accept an incoming connection", it sets timer value based on the time_offset_table table.
But when attemp count is the maximum, there is a bug in code in CompileServer::updateInConnectivity function in icecream/scheduler/compileserver.cpp file.
The limit checking shuold be before that next timeout value calculation:
so from current code:

    m_nextConnTime = time(nullptr) + time_offset_table[m_inConnAttempt];
        if(m_inConnAttempt < (table_size - 1))
            m_inConnAttempt++;

to:

        if(m_inConnAttempt < (table_size - 1))
            m_inConnAttempt++;
       m_nextConnTime = time(nullptr) + time_offset_table[m_inConnAttempt];

and by the way, is there a way to scheduler to notice the icecc daemon clients appearing again and making the retry and not waiting this timer to expire?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant