-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inclusion of spline tables in container #166
Comments
see #148 (comment) Preferably, I'd like to see a no-CVMFS pattern for all our use cases if possible. |
I guess by "no-CVFMS" you mean an image not including data from CVMFS? Because the current "no-CVFMS" Dockerfile is the opposite: a container that does not need CVMFS access at runtime. So I guess we would be fetching the spline data at runtime and mount their location as a volume, right? I agree with making the "code-only" image the default (also because it is then trivial to add data on top of that if there are special requirements). |
Right, I believe we agree--a dataless image. We either mount as a volume or have the container's process fetch the data and write within the container. Then following processes would look inside the container instead of refetching. |
Side note: since we are going to clean up the Dockerfile, there is a bunch of commented out import statements for pieces of |
After a brief chat with @ric-evans , maybe we could reconsider IceTray filestagers on the client side. It seems to be the path of least resistance. |
I agree. WIPACrepo/docker-icecube-icetray#10 That look good? |
Seems fine to me! |
Just checking, but how do we handle the base gcd lookups? Some similar principle? Or do we even do those anymore? |
I have not touched that part anymore but the |
One helping thing is #150 , and then we don't need the base gcds in the client container, just at the server. That has CVMFS available for most scenarios. I don't think the base GCD files are on prod-exe, as they are in |
Currently, only the spline tables used by
millipede_original
are included in the Skymap Scanner docker image and I believe there are a few points that should be sorted out:millipede_original
are fetched upstream, as prescribed by the Dockerfile of IceTray. It would make more sense to fetch them as part of the Dockerfile of Skymap Scanner;millipede_wilks
andsplinempe
require additional spline tables; right now formillipede_wilks
we override$I3_DATA
in the client starter script so it points to CVMFS, however this does not work in CI;no_cvmfs
: shouldn't this become the default, at least for CI purposes?The text was updated successfully, but these errors were encountered: