Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate some arguments in start_scan and refactor fallback seed #230

Open
mlincett opened this issue Oct 29, 2023 · 2 comments
Open

Deprecate some arguments in start_scan and refactor fallback seed #230

mlincett opened this issue Oct 29, 2023 · 2 comments
Labels
tech debt cleanup We need to do this to avoid tech debt

Comments

@mlincett
Copy link
Collaborator

The following arguments of start_scan:

  1. input_time_name: str
  2. input_pos_name: str
  3. output_particle_name: str
    define the starting seed (fallback_*) and the current seed output_particle_name.

These arguments are never used and they always correspond to default values.

What reco modules do now is write the starting seed to the default value of input_(pos|time)_name (server-side) which is cfg.INPUT_(POS|TIME)_NAME and read the current seed from the default value of output_particle_name (client-side) which is cfg.OUTPUT_PARTICLE_NAME.

In other words, there is no benefit in defining any of this in start_scan. The reco module could provide a name for the starting seed (optionally, more than one) while output_particle_name is purely conventional.

@tianluyuan
Copy link
Contributor

@mlincett are you able to get to this still?

@mlincett
Copy link
Collaborator Author

@mlincett are you able to get to this still?

I'd like to, but I have some other things on my backlog still.

@ric-evans ric-evans added the tech debt cleanup We need to do this to avoid tech debt label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt cleanup We need to do this to avoid tech debt
Projects
None yet
Development

No branches or pull requests

3 participants