Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pointed scans #237

Open
mlincett opened this issue Nov 21, 2023 · 2 comments
Open

Pointed scans #237

mlincett opened this issue Nov 21, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@mlincett
Copy link
Collaborator

I have been chatting with @G-Sommani about how to implement "pointed" scans. This would allow to investigate, for example, different sky regions compared to the one to which the scan iterations converge.

The relevant logic is in start_scan.py, specifically the PixelsToReco class.

The simplest way of doing this is to pass a pair of coordinates to start_scan and select only the first-NSIDE pixel pointed by those coordinates (instead of scanning/refining all the pixels). So the set of changes could be fairly minimal.

SkyDriver will have to support the additional input.

A logic of the type "scan a given radius around given coordinates" to determine the corresponding appropriate NSIDE sequence can be implemented in SkyMist.

@mlincett
Copy link
Collaborator Author

The logic is actually already implemented here:

def choose_pixels_to_reconstruct(
nsides_dict: NSidesDict,
nside_progression: NSideProgression,
ang_dist: float = 2.,
mc_ra_dec: Optional[Tuple[float, float]] = None,
) -> Set[Tuple[icetray.I3Int, icetray.I3Int]]:
"""Get more pixels to reconstruct/refine.

It scans at max NSIDE around given coordinates and with a given radius. It is a bit more rigid than what I had in mind but also does not require any additional logic.

All there is to do is back-propagate the arguments up to start_scan.py.

@ric-evans
Copy link
Member

ric-evans commented Nov 27, 2023

All there is to do is back-propagate the arguments up to start_scan.py.

Yup, I left this in. If you add the needed CI arguments, I can hook this up to SkyDriver.

@ric-evans ric-evans added the enhancement New feature or request label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants