Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

become PEP8 compliant #486

Open
JessicaS11 opened this issue Dec 22, 2023 · 1 comment
Open

become PEP8 compliant #486

JessicaS11 opened this issue Dec 22, 2023 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@JessicaS11
Copy link
Member

In #475, it was discovered that the flake8 linter action that had been running on PRs was outdated and therefore failing to post comments on PRs where PEP8 standards weren't met. Subsequent PRs are being used as an opportunity to come into compliance by making the needed edits on any files changed within that PR. However, a large number of changes are still required (primarily related to line length). For the sake of progress, #475 will be set to have a successful exit status even though there are errors (i.e. so the GitHub action passes), and maintainers/contributors are asked to take note of and address noncompliance moving forward. This issue documents the need for some intentional work towards meeting the standard.

@JessicaS11 JessicaS11 added help wanted Extra attention is needed good first issue Good for newcomers labels Dec 22, 2023
@mfisher87
Copy link
Member

mfisher87 commented Aug 12, 2024

@JessicaS11 We're fairly compliant with pycodestyle rules now! We could enable pep8-naming rules as well to become more PEP8 compliant. Do you think we can mark this complete after applying pep8-naming rules?

There are a lot more readability and quality rules available in our linter after this. To start, I'd really like to enable bugbear, pycodestyle warnings, and pyupgrade as I work! Huge timesavers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants