We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Originally posted by @weiji14 in #550 (comment):
The setter is here: icepyx/icepyx/quest/dataset_scripts/argo.py Lines 79 to 85 in a77b685 @params.setter def params(self, value): """ Validate the input list of parameters. """ self._params = list(set(self._validate_parameters(value))) Suggestions: The code is calling list(set()) twice (once in the setter, and once in _validate_parameters), we could at least remove one of those. The _valid_params list could be turned into a set for faster membership tests, see https://docs.astral.sh/ruff/rules/literal-membership.
The setter is here:
icepyx/icepyx/quest/dataset_scripts/argo.py
Lines 79 to 85 in a77b685
Suggestions:
list(set())
_validate_parameters
_valid_params
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Originally posted by @weiji14 in #550 (comment):
The text was updated successfully, but these errors were encountered: