Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Allow 'Not applicable' for tumour_grading_system and tumour_grade #359

Open
Buwujiu opened this issue Aug 29, 2022 · 0 comments
Assignees
Labels
Dictionary 1.23 new-feature Request is a new feature

Comments

@Buwujiu
Copy link
Contributor

Buwujiu commented Aug 29, 2022

Detailed Description

As tumour grading is not applicable to certain cancers, for example blood cancers:

  • T-cell Lymphoma (EUPTCL-DE)
  • Multiple Myeloma (MM-KR)
    Programs would like to submit Not applicable for tumour_grading_system and tumour_grade.
    Because tumour_grade is depend on tumour_grading_system, when tumour_grading_system = Not applicable, tumour_grade shall be Not applicable as well.

After we implement this, we need to modify clinical validation rules to allow tumour_grade = Not applicable, otherwise users will see clinical validation errors, because tumour_grade is a required field.

Note that this is NOT a clinical exception, as it's a valid scientific case.

The clinical changes will be done here: icgc-argo/argo-clinical#805

Exit Criteria

when users submit the following combo to clinical system

tumour_grading_system tumour_grade
Not applicable Not applicable

there should be no dictionary error, this should be a valid case.

Possible Implementation

  • Add a new enum value Not applicable to the permissible list of tumour_grading_system.
  • Add a new enum value Not applicable to the permissible list of tumour_grade.
  • Modify the tumour_grade 's validation scrip to allow Not applicable value when tumour_grading_system = Not applicable.
@Buwujiu Buwujiu added the new-feature Request is a new feature label Aug 29, 2022
@Buwujiu Buwujiu changed the title Feature Request: Allow 'Not applicable' for tumour_grading_system Feature Request: Allow 'Not applicable' for tumour_grading_system and tumour_grade Nov 14, 2022
@Buwujiu Buwujiu assigned hknahal and unassigned ciaranschutte Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dictionary 1.23 new-feature Request is a new feature
Projects
None yet
Development

No branches or pull requests

5 participants