Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Join Program has Unknown Error #449

Open
lindaxiang opened this issue Aug 15, 2024 · 1 comment
Open

🐛 Join Program has Unknown Error #449

lindaxiang opened this issue Aug 15, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@lindaxiang
Copy link

Describe the bug

Program WCCPMP-US reports that some of their submitters encounter Unknown Error when join the program.

  1. We have tested the issue in Prod:
  • If we invite the person using OICR emails, there's no issue
  • If we invite the person using Gmail, we can reproduce the Unknown Error issue
  1. We also tested the issue in QA, and we could NOT reproduce the Unknown Error issue.

Steps To Reproduce

Steps to reproduce the behaviour:

  1. Go to 'https://platform.icgc-argo.org/'
  2. Login the Program Services with admin role
  3. Click on test programs TEST-INTL or TEST-CA
  4. Click Manage Program
  5. Click ADD USERS
  6. Input your name and gmail, select a role, and click ADD USERS
  7. Go to your gmail inbox, and find the email
  8. Click JOIN THE PROGRAM
  9. See error
    Screenshot 2024-08-15 at 11 28 22 AM

Expected behaviour

The submitter should be able to see the following interface to join the program
Screenshot 2024-08-15 at 11 29 01 AM

@lindaxiang lindaxiang added the bug Something isn't working label Aug 15, 2024
@joneubank
Copy link
Member

The cause of this is that the Program Service endpoint used to confirm the invite information is currently set to require authorization. We need this endpoint to work for users that are not logged in (obviously).

The specific endpoint is GET /programs/joinProgramInvite. This can be moved to the PublicProgramController and the authorization annotation removed.

Endpoint code: https://github.com/icgc-argo/program-service/blob/develop/src/main/java/org/icgc/argo/program_service/controller/ProgramController.java#L230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants