Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement: Compiling parameters for Resuming and re-running jobs #85

Open
jaserud opened this issue Jan 7, 2022 · 0 comments
Open

Implement: Compiling parameters for Resuming and re-running jobs #85

jaserud opened this issue Jan 7, 2022 · 0 comments
Assignees

Comments

@jaserud
Copy link
Contributor

jaserud commented Jan 7, 2022

Wiki with design has been created here

Detailed Description

  • New POST endpoint in Workflow-Graph-Node /restart which will actually cover both re-run and resume cases
  • This endpoint takes a RestartRequest: { runId: String, params: JSON }
  • have an option to dry-run to be able to see what node would do with out actually doing it
  • With this implementation if workflow_url, workflow_version, or the params Avro schema for a workflow-graph-node changes, that node cannot resume/rerun any runs from before the change.

Possible Implementation

Workflow-Graph-Node will

  1. fetch the run
  2. create a RunRequest with the workflow_url, workflow_version, sessionId (if it exists) and params (which is either the provided one or the params from existing run)
  3. Verify workflow_url, workflow_versiom. params (validate with Avro schema) etc.
  4. Start run
  5. Add the new runId to its RUNNING queue
@jaserud jaserud changed the title Implement - Compiling parameters for Resuming and re-running jobs POC Implement: Compiling parameters for Resuming and re-running jobs POC Jan 7, 2022
@jaserud jaserud self-assigned this Jan 7, 2022
@jaserud jaserud changed the title Implement: Compiling parameters for Resuming and re-running jobs POC Implement: Compiling parameters for Resuming and re-running jobs Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant