Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GraphQL Pagination Properly #37

Open
lepsalex opened this issue Jun 30, 2020 · 0 comments
Open

Use GraphQL Pagination Properly #37

lepsalex opened this issue Jun 30, 2020 · 0 comments
Labels
enhancement New feature or request specs-wip Specs are in progress

Comments

@lepsalex
Copy link
Contributor

lepsalex commented Jun 30, 2020

Currently the main table will load 100 rows of data and handle the pagination in the front-end, this can be moved to the graphql query to save on data transfer.

  • Use the standard GraphQL pagination model: https://graphql.org/learn/pagination/. We donts need full hits/edges/node

  • Make a new ticket in api repo with info above
    ---- need a results object to return total
    ---- 1 layer of nesting for all hits (entities ex file + runs+ analysis)

  • Keep the existing GraphQL; add a new v2 path https://api.rdpc-qa.cancercollaboratory.org/v1/graphql

  • Can switch over services to /v1 one by one [workflow node, workflow ui, workflow management, workflow graph, aggregator, model-tee]

  • Update this section in UI as well; may need to reach out to @lepsalex for aggregation endpoints.
    image

Specs:
https://wiki.oicr.on.ca/display/icgcargotech/RDPC+Gateway+Design#RDPCGatewayDesign-PaginationSchema

@lepsalex lepsalex added the enhancement New feature or request label Jun 30, 2020
@rosibaj rosibaj added the specs-wip Specs are in progress label Oct 19, 2020
@rosibaj rosibaj self-assigned this Oct 20, 2020
@mistryrn mistryrn assigned mistryrn and unassigned rosibaj Dec 7, 2020
@joneubank joneubank reopened this Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request specs-wip Specs are in progress
Projects
None yet
Development

No branches or pull requests

4 participants