New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Description of iCKB rule #4

Closed

XuJiandong opened this issue Aug 12, 2024 · 1 comment

XuJiandong commented Aug 12, 2024

The total iCKB value of input tokens and input receipts must be bigger or equal to the total iCKB value of output tokens.

According to the code, it should be "equal" only:
https://github.com/ickb/v1-core/blob/1647af2aadcc5b57bc876fe64c5929dbedf67ea1/scripts/contracts/ickb_logic/src/entry.rs#L32

phroi transferred this issue from ickb/v1-core

Member

phroi commented Aug 12, 2024

Good catch, I recently updated the iCKB script code to prevent a failure mode that was happening on Testnet: ckb-js/lumos#735

I forgot to update the proposal, thank you!! 🙏

phroi closed this as completed in

1d14dcd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment