Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose unit conversion as internal headers #24

Closed
sffc opened this issue Jul 14, 2020 · 5 comments · Fixed by unicode-org/icu#1568
Closed

Expose unit conversion as internal headers #24

sffc opened this issue Jul 14, 2020 · 5 comments · Fixed by unicode-org/icu#1568
Assignees
@younies
Labels
Time: Small < 6 hours of eng time
Milestone
2021-Q1-m2

Comments

@sffc
Copy link
Collaborator

sffc commented Jul 14, 2020

Needs pros and cons
@sffc
Copy link
Collaborator Author

sffc commented Jul 14, 2020 •
edited
Loading

Options:

  1. Propose this as fully-powered ICU API
  2. Expose this as @internal APIs; use with Google clients; propose publicly in the future
  3. Keep these APIs in the internal ICU header files, and poke holes where needed
  4. Decide not to expose this at all

@hugovdm hugovdm mentioned this issue Jul 17, 2020
Open
@sffc sffc added this to the 2020-Q3-m3 milestone Jul 21, 2020
@sffc
Copy link
Collaborator Author

sffc commented Jul 21, 2020

Related: tc39/proposal-smart-unit-preferences#10

@sffc sffc added the future label Aug 4, 2020
@sffc sffc removed this from the 2020-Q3-m3 milestone Aug 4, 2020
@sffc
Copy link
Collaborator Author

sffc commented Jan 6, 2021 •
edited
Loading

Decision: start with @internal Technical Preview for ICU 69.

See update below.

@sffc sffc added Time: Small < 6 hours of eng time and removed future labels Jan 6, 2021
@sffc sffc added this to the 2021-Q1-m2 milestone Jan 6, 2021
@sffc sffc changed the title Propose unit conversion as public API or decide not to do it Expose unit conversion as Technical Preview Jan 6, 2021
@sffc
Copy link
Collaborator Author

sffc commented Jan 6, 2021

According to @markusicu, we should put the new APIs in i18n/units/experimental_units.h.

@sffc sffc changed the title Expose unit conversion as Technical Preview Expose unit conversion as internal headers Feb 3, 2021
@sffc
Copy link
Collaborator Author

sffc commented Feb 3, 2021

Updated decision: make sure everything we need is in the internal ICU header files (not @internal Technical Preview but the actual internal header files), and consider as draft for ICU 70.

@younies younies mentioned this issue Feb 10, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@younies younies

Labels
Time: Small < 6 hours of eng time
Projects
None yet
Milestone
2021-Q1-m2
Development

Successfully merging a pull request may close this issue.

ICU-21349 Add UnitsConverter.getConversionInfo() icu-units/icu
2 participants
@sffc @younies