homework1

[Taniann]

• usually *.iml and .idea also added in gitignore
• better dont create classes directly in src. create another packages in src. from Java Code Convention: "The prefix of a unique package name is always written in all-lowercase ASCII letters and should be one of the top-level domain names, currently com, edu, gov, mil, net, org... Subsequent components of the package name vary according to an organization’s own internal naming conventions." For example: com.sun.eng
  com.apple.quicktime.v2
• it`s not a good practice to write everything in one class. From SOLID principles (you'll study later) letter S means that class should have single responsibility. In first homework I accept it. but in future try to avoid that
• Main.java#L29 it works wrong. try to pass bets(3, 2, 3, 0) you'll get java.lang.ArithmeticException: / by zero - CHAHGE it
• Main.java#L34 Method names are typically verbs or verb phrases.
  -Main.java#L54 why method returns double, if it accept int parameters
• Main.java#L60 dont use unclear contractions
• Main.java#L108
  for future: better each variable from new line
• dont forget about code formatting(redundant blank lines, whitespaces)

RESULT: change task1.1

[Taniann]

I've checked your hw again. Good
pay attention to all comments. dont repeat these mistakes in future