You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Just a note for now, but this is very similar to the dreem implementation (which is fine), so perhaps in a future PR we can abstract it out into a shared task rather than device specific? since the only difference between dreem/VTT at the moment is how data is downloaded (line 103).
This is food for thought on how we might abstract this further once we implement the DAGs
Agreed -- also pulling out device agnostic logic such as __device_id_from_ucam in dreem.py since it determines a device in UCAM by a wear period and DeviceType (needs renaming too).
Worth noting now that while there is some overlap, BTF differs in that it returns a filename rather than bool. I argue that DRM and other pipelines should change to follow BTF for consistency.
Just a note for now, but this is very similar to the dreem implementation (which is fine), so perhaps in a future PR we can abstract it out into a shared task rather than device specific? since the only difference between dreem/VTT at the moment is how data is downloaded (line 103).
This is food for thought on how we might abstract this further once we implement the DAGs
Originally posted by @jawrainey in #21 (comment)
The text was updated successfully, but these errors were encountered: