Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract download_file protocols across devices due to similarity #24

Open
davidverweij opened this issue Feb 2, 2021 · 3 comments
Open

Comments

@davidverweij
Copy link
Member

Just a note for now, but this is very similar to the dreem implementation (which is fine), so perhaps in a future PR we can abstract it out into a shared task rather than device specific? since the only difference between dreem/VTT at the moment is how data is downloaded (line 103).

This is food for thought on how we might abstract this further once we implement the DAGs

Originally posted by @jawrainey in #21 (comment)

@davidverweij
Copy link
Member Author

This now also includes other protocols, such as the recently introduced uid_to_hash() in combination with all_hashes() methods.

@jawrainey
Copy link
Member

Agreed -- also pulling out device agnostic logic such as __device_id_from_ucam in dreem.py since it determines a device in UCAM by a wear period and DeviceType (needs renaming too).

@jawrainey
Copy link
Member

Worth noting now that while there is some overlap, BTF differs in that it returns a filename rather than bool. I argue that DRM and other pipelines should change to follow BTF for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants