You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This however fails typing as unkown methods are called on the Generator (e.g. client.get()) - which is used with the monkeypatch. Not to mention the 'private' methods in those tests and the required typing for their returned values.
At this moment, I've resorted to exclude these tests from typing checks by mypy, i.e. in mypy.ini:
Due to the unknown payloads from the inventory API, typing becomes more complex. As such, the response can return
Any
type:This is further complicated in tests with the use of a monkeypatch, e.g. in tests > consumer_tests > routers > conftest.py:
becomes something like
This however fails typing as unkown methods are called on the Generator (e.g.
client.get()
) - which is used with themonkeypatch
. Not to mention the 'private' methods in those tests and the required typing for their returned values.At this moment, I've resorted to exclude these tests from typing checks by mypy, i.e. in
mypy.ini
:I've also excluded
flake8
linting for error codeAAA05
as it conflicts withblack
introducing a white line between private methods in an Act block.Next steps
Ideally this typing is corrected to prevent any coding errors, but priority is low.
The text was updated successfully, but these errors were encountered: