Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage database and schema using an ORM #2859

Open
benwerd opened this issue Dec 24, 2020 · 6 comments
Open

Manage database and schema using an ORM #2859

benwerd opened this issue Dec 24, 2020 · 6 comments
Assignees

Comments

@benwerd
Copy link
Member

benwerd commented Dec 24, 2020

Currently database upgrades and schema changes are handled internally using SQL. This is prone to failure (see #2783).

We should port to Eloquent if possible, or Doctrine if we have to.

I'm not asking anyone else to do this - I'm planning on looking at this.

@mapkyca
Copy link
Member

mapkyca commented Dec 25, 2020

Not an ORM. Bad idea.

I have a long term plan to migrate to using doctrine dbal with schema defined in json. We do this in the day job and it's very good.

@ipranjal
Copy link
Contributor

@mapkyca @benwerd does this mean dropping support for MongoDB ?

@mapkyca
Copy link
Member

mapkyca commented Apr 29, 2021

That's the plan, at least in core. Mongo has many many problems

@ipranjal
Copy link
Contributor

i have been playing around with this lately but there is one small thing , is it ok to brake a little bit of backward compatibility ? More like 2.0 update ?

@Cambridgeport90
Copy link

Cambridgeport90 commented Apr 29, 2021 via email

@ipranjal
Copy link
Contributor

I was playing around with \Idno\Data\MySql recently and I changed few queries from the once that are hard coded to the once that are generated form DBAL query builder - https://www.doctrine-project.org/projects/doctrine-dbal/en/latest/reference/query-builder.html#sql-query-builder

using DBAL query builder is a much easier fix to implement than using a full fledged ORM
@benwerd my 2 cents on this is using a ORM would be a bad idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants