Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable "Use biometrics" but launch an error message if there are no biometrics added on a device that supports it #205

Closed
wants to merge 1 commit into from
Closed

Enable "Use biometrics" but launch an error message if there are no biometrics added on a device that supports it #205

wants to merge 1 commit into from

Conversation

danicaerediano
Copy link
Collaborator

Closes #196

@danicaerediano danicaerediano requested a review from pmigueld June 14, 2022 03:52
@pmigueld
Copy link
Collaborator

The fix does not work and introduces a bug - with or without fingerprint enabled, the "Use biometrics" button remains disabled.

However testing on the current develop I can no longer replicate the issue:

image

Tested on Redmi 9C (Android 10)

@pmigueld
Copy link
Collaborator

pmigueld commented Jul 13, 2022 •
edited
Loading

Verified working in current develop with no changes needed.

@pmigueld pmigueld closed this Jul 13, 2022
@pmigueld pmigueld deleted the enhancement/196-use-biometrics-button branch July 13, 2022 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmigueld pmigueld Awaiting requested review from pmigueld

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@danicaerediano @pmigueld @danicaMat