Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keys in configuration example have no stated purpose #40

Closed
JAG-UK opened this issue Nov 3, 2024 · 2 comments · Fixed by #38
Closed

Keys in configuration example have no stated purpose #40

JAG-UK opened this issue Nov 3, 2024 · 2 comments · Fixed by #38

Comments

@JAG-UK
Copy link
Contributor

JAG-UK commented Nov 3, 2024

Showing keys without saying what they're for is unhelpful

Cedric suggests it might be even better to remove the specifics and just include a standard key discovery locator (which also helps avoid format/types arguments in this doc)
@JAG-UK
Copy link
Contributor Author

JAG-UK commented Nov 4, 2024

I have attempted to resolve this by removing it in the translation to CBOR in PR #38 - will this suffice?

@JAG-UK JAG-UK linked a pull request Dec 3, 2024 that will close this issue
First tranche of CBOR All The Things #38
Merged
@JAG-UK
Copy link
Contributor Author

JAG-UK commented Dec 3, 2024

Reviewed and addressed in #38

@JAG-UK JAG-UK closed this as completed Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

First tranche of CBOR All The Things ietf-wg-scitt/draft-ietf-scitt-scrapi
1 participant
@JAG-UK