You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This requires client packages to find_package(ifm3d) and target_link_libraries(... ifm3d::camera ifm3d::framegrabber ifm3d::image) or else ensure ifm3d is on the include path when building packages which consume ifm3d-ros2.
The implementation details (the ifm3d bits) should be hidden via pImpl to keep the public interface ROS-only.
The text was updated successfully, but these errors were encountered:
ifm3d
library headers are unnecessarily exposed to clients throughcamera_node.hpp
here:ifm3d-ros2/include/ifm3d_ros2/camera_node.hpp
Line 39 in c281b5e
This requires client packages to
find_package(ifm3d)
andtarget_link_libraries(... ifm3d::camera ifm3d::framegrabber ifm3d::image)
or else ensureifm3d
is on the include path when building packages which consumeifm3d-ros2
.The implementation details (the
ifm3d
bits) should be hidden viapImpl
to keep the public interface ROS-only.The text was updated successfully, but these errors were encountered: