Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public interface leaks ifm3d headers #8

Open
theseankelly opened this issue May 1, 2020 · 0 comments
Open

Public interface leaks ifm3d headers #8

theseankelly opened this issue May 1, 2020 · 0 comments
Labels

Comments

@theseankelly
Copy link
Contributor

theseankelly commented May 1, 2020

ifm3d library headers are unnecessarily exposed to clients through camera_node.hpp here:

#include <ifm3d/camera.h>

This requires client packages to find_package(ifm3d) and target_link_libraries(... ifm3d::camera ifm3d::framegrabber ifm3d::image) or else ensure ifm3d is on the include path when building packages which consume ifm3d-ros2.

The implementation details (the ifm3d bits) should be hidden via pImpl to keep the public interface ROS-only.

ifm-csr pushed a commit that referenced this issue Apr 7, 2023
Add unboxing to getting started
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant