Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drp is not zero #11

Open
londumas opened this issue Mar 13, 2019 · 16 comments
Open

drp is not zero #11

londumas opened this issue Mar 13, 2019 · 16 comments
Assignees
Labels
question Further information is requested

Comments

@londumas
Copy link
Collaborator

Currently we measure drp_QSO = -1.174 +/- 0.039, drp_DLA = -1.193 +/- 0.627. There are no obvious reasons for this parameter to be different than zero. It might be simply linked to random fluctuations of the velocity on mocks. We want to look at that with 10 realizations.

@londumas londumas added the question Further information is requested label Mar 13, 2019
@jmarclegoff
Copy link
Collaborator

Hélion,
Do you really believe that drp_QSO = -1.174 +/- 0.039 can be a statistical fluctuation ?
Or you do not believe in the estimate of the error ?

@londumas
Copy link
Collaborator Author

@jmarclegoff, I don't know if you remember what we observed in your previous mocks (last year of my thesis),
but we also measured drp!=0 in each realization, but the distribution was compatible with zero.
At that time, we concluded, through one of your plot where you looked at the velocity gradient along the z-axis, that it was linked to non vanishing large scale mode in the velocity gradient.
So maybe we have the same effect in the new mocks.

@jmarclegoff
Copy link
Collaborator

@londumas, now I think I remember. So let's wait for the additional realisations.
But what does it mean for real data ? The drp that we observe is meaningless or these non vanishing large scale mode in the velocity gradient exist in the mocks and not in the data ?
I would need to think more about that.

@londumas
Copy link
Collaborator Author

This realization v4.2 has drp_QSO = -0.94 +/- 0.0838. Taking into account the -100km/s from quickquasar redshift systematic error. So the shift is indeed still there. Let's wait to see other realizations.

@TEtourneau
Copy link
Collaborator

TEtourneau commented Jun 28, 2019

Here is the measured drp on the 10 cross-correlations from the raw-mocks of version v4.4
Screen Shot 2019-06-28 at 3 52 54 PM

drp mean is -1.068 +/- 0.083 (1 sigma)

Edit: In fact it is from the eboss-0.2 (quickquasars + DLA) cross-correlations !
The measure mean drp on the raw-mocks is:
drp = -1.105 +/- 0.089

@londumas
Copy link
Collaborator Author

@TEtourneau, good thanks for the plot. Could you add a plot of the stack or at least one correlation, along the first slice at rt==0? Like in here igmhub/LyaCoLoRe#41 (comment)

@jmarclegoff
Copy link
Collaborator

Between versions 4.4 and 4.5, I corrected a stupid bug in the function that computes Gaussian smearing weights. This bug was changing where we read in the box by half a pixel, i.e. 1.095 Mpc/h.
I now realize that this should bring the mean drp to zero!
from -1.068 +- 0.083 to +0.027 +- 0.083
To be checked with version 4.5 mocks.

@londumas
Copy link
Collaborator Author

@jmarclegoff, good. Looking at @TEtourneau plots, this can be checked with one realization.

@TEtourneau
Copy link
Collaborator

TEtourneau commented Jun 28, 2019

Here are the plots:
Screen Shot 2019-06-28 at 5 17 47 PM
Screen Shot 2019-06-28 at 5 18 16 PM

The cross-correlations are taken from the raw-mocks. (I only took 9 on the 10 realisations because I think one of the fits didn't converge)

@londumas
Copy link
Collaborator Author

@TEtourneau, Thanks for this. Indeed it is in the opposite direction as the London mocks. @jfarr03, maybe you have a similar bug as Saclay had?

@TEtourneau
Copy link
Collaborator

The shift in the London mocks is much smaller than our, so I don't think it could be something similar. But I guess it is always worth to check it :)

@jmarclegoff
Copy link
Collaborator

@TEtourneau, indeed have an effect of half a simulation voxels,
@jfarr03 the effect for London could rather be something like half a spectrum pixel?

@jfarr03
Copy link

jfarr03 commented Jul 1, 2019

@jmarclegoff Yes in the London mocks drp is around 1/2 the cell width. Can you point me to the code you changed to correct the error?

@jmarclegoff
Copy link
Collaborator

@jfarr03 This is a stupid bug, from a time when I was learning python and fighting to vectorize the code so that I did not pay enough attention to the algorithm. I positioned the center of the cell at the edge of it!
at line 53 of https://github.com/igmhub/SaclayMocks/blob/master/bin/make_spectra.py
cell_center = sp.array([(ix+0.5)DX-LX/2,(iy+0.5)DY-LY/2,(iz+0.5)DZ-LZ/2+R0])
used to be
cell_center = sp.array([ix
DX-LX/2,iy
DY-LY/2,iz
DZ-LZ/2+R0])

@jvstermer
Copy link

jvstermer commented Jul 3, 2019

For the latest version of the mocks, v4.5.0:
document-1
document-2

From the cross correlation of raw mocks with a down sampling of 600 000 quasars.
This result is to be confirmed with additional realizations of the mocks.

@londumas
Copy link
Collaborator Author

londumas commented Jul 3, 2019

@jvstermer, this looks very good. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants