Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some date-time languages are missing #256

Closed
cool0707 opened this issue Feb 19, 2021 · 3 comments
Closed

Some date-time languages are missing #256

cool0707 opened this issue Feb 19, 2021 · 3 comments

Comments

@cool0707
Copy link
Contributor

cool0707 commented Feb 19, 2021

The localization of some of the date time languages that we added to app.bundle.min.js before is missing (probably due to the merging process when we upgraded Jiti Meet).
I'm trying to submit a PR to upstream, but it's going to be hard to get it approved and merged, so I'll submit the PR here for now.

@gjaekel
Copy link
Contributor

gjaekel commented Feb 19, 2021

I'm trying to submit a PR to upstream, but it's going to be hard to get it approved and merged, so I'll submit the PR here for now.

I'm already approved. In the early months of 2020, I fail to push something upstream. This seems to be happen just because the whole project team was overloaded. But recently, I did it again (jitsi/jitsi-videobridge#1550) and it was processed within a few days (by "the" @bgrozev ).

I try to support it by a review.

@cool0707
Copy link
Contributor Author

I thought the PR of upsteram would simply be to add unsupported languages, but I needed to make Moment.js the latest version to add Moldovan.
However, when I update Moment.js to the latest version, the size of the build webpack exceeds the size and an error occurs.
In order to reduce the size, I need to introduce a plugin that removes languages not used by Moment.js from webpack, but for this, I need to build and test environment to work on it.
I don't have a lot of time right now, so I will make these changes when I have more time and then submit the PR again.

Please give me a review when you do.

@gjaekel
Copy link
Contributor

gjaekel commented Feb 21, 2021

I wonder if this size is just and arbitrary limit that is defined somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants