Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor MESSAGEix-Materials reporting #192

Open
macflo8 opened this issue May 21, 2024 · 0 comments
Open

Refactor MESSAGEix-Materials reporting #192

macflo8 opened this issue May 21, 2024 · 0 comments
Assignees
@macflo8
Labels
material MESSAGEix-Materials variant report genno-based reporting and post-solve processing

Comments

@macflo8
Copy link
Contributor

macflo8 commented May 21, 2024

The industry specific reporting located in message-ix-models/message_ix_models/model/material/report/ currently has a McCabe complexity of over 150 and is thus far from being compliant with code quality standards on message-ix-models. A refactoring of this module is also desirable, since maintainability has shown to be tedious.

To-Do:

  • Open a refactoring branch once materials module is merged to main
  • Refactor code to reduce complexity and enhance maintainability
  • Write tests to confirm correct refactoring
@macflo8 macflo8 added report genno-based reporting and post-solve processing material MESSAGEix-Materials variant labels May 21, 2024
@macflo8 macflo8 self-assigned this May 21, 2024
@macflo8 macflo8 mentioned this issue May 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@macflo8 macflo8

Labels
material MESSAGEix-Materials variant report genno-based reporting and post-solve processing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@macflo8