Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a code linter #13

Open
aashutoshrathi opened this issue Sep 20, 2018 · 11 comments · May be fixed by #35
Open

Add a code linter #13

aashutoshrathi opened this issue Sep 20, 2018 · 11 comments · May be fixed by #35
Assignees
@rahulrana95
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest Fix to increase your Hacktoberfest PR count

Comments

@aashutoshrathi
Copy link
Member

aashutoshrathi commented Sep 20, 2018 •
edited
Loading

Add coala or similar linter for JS files.
Anyone from @iiitv/batch-of-2021, please take this issue.
@aashutoshrathi aashutoshrathi added enhancement New feature or request good first issue Good for newcomers labels Sep 20, 2018
@aashutoshrathi aashutoshrathi added the Hacktoberfest Fix to increase your Hacktoberfest PR count label Sep 29, 2018
@rahulrana95
Copy link

rahulrana95 commented Sep 30, 2018 •
edited by Monal5031
Loading

@aashutoshrathi can you assign me this issue or I can open a PR?

@aashutoshrathi
Copy link
Member Author

@rahulrana95 Join our organization using http://getmein.glitch.me
Thanks

@rahulrana95
Copy link

@aashutoshrathi I have joined the organization.
Can you assign the issue to me?

@aashutoshrathi
Copy link
Member Author

Assigned @rahulrana95

@rahulrana95
Copy link

@aashutoshrathi I am not able to push to a new feature branch. Please give me permissions.

@aashutoshrathi
Copy link
Member Author

Fork and send a PR @rahulrana95

@rahulrana95 rahulrana95 linked a pull request Oct 1, 2018 that will close this issue
Open
8 tasks
@neolivz
Copy link

neolivz commented Oct 3, 2018

Just curious why coala than eslint?

@aashutoshrathi
Copy link
Member Author

We have had good relations with @coala and also have few of our members as active contributors there, plus its easy to integrate, I think.

@rahulrana95
Copy link

@aashutoshrathi I have tried coala linter for js but I am not able to find proper documentation to setup it properly. Eslint is widely used as linter for js codebases

@aashutoshrathi
Copy link
Member Author

A sample commit for you: iiitv/algos@297da0f#diff-e7d7d93b4c8d0df9c9bf21a7d47c83b5
Feel free to read it.
😄

@rahulrana95
Copy link

@aashutoshrathi then we can merge the coala one PR i have make. Its working. I just need to add more bears to it else its working as of now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahulrana95 rahulrana95

Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest Fix to increase your Hacktoberfest PR count
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add coala configuration file and add script in package.json rahulrana95/getmein-web
3 participants
@neolivz @rahulrana95 @aashutoshrathi