Gulp callback fired too early

[klausbayrhammer]

As discussed in #8

gulp.task('deploy', function(){
  gulp.src(['./package.json'])
    .pipe(bump({type:'patch'}))
    .pipe(gulp.dest('./'))
    .pipe(git.commit('bumps package version'))
    .pipe(filter('package.json'))
    .pipe(tag_version())

    .pipe(git.push('origin', 'master', {args: " --tags"}, function (err) {
      if (err) throw err;
    }));
});

When I execute the deploy tasks it seems like there is some kind of race condition because sometimes the git push origin master --tags pushes the commit with the version bump but misses the tag.

I suspect the gulp callback is fired too early. You could try chaning the lines git.tag(tag, label, opts); cb(null, file) to git.tag(tag, label, opts, cb) so the gulp-callback is triggered when the tagging is done.

[Dan503]

Can this please be merged into master and released onto npm?

It doesn't seem to be fixed in the official release.