Add started and finished times to Job #50
Conversation
|
Great! |
| (JobStatus.done, JobStatus.collected): {}, | ||
| } | ||
|
|
||
| def update_status(self, *, old: JobStatus, new: JobStatus) -> int: |
There was a problem hiding this comment.
Should also contain and id argument.
There was a problem hiding this comment.
Should also contain and id argument.
Since querysets can be chained, filtering by ID can be done before updating where needed. This way, we can update status for any given queryset (e.g. for multiple jobs or by PK instead of external ID). Therefore, I suggest leaving update_status as a special case of generic update.
| if "now" in transition_info: | ||
| extra_update_fields[transition_info["now"]] = datetime.datetime.utcnow() | ||
|
|
||
| return self.filter(status=old).update(status=new, **extra_update_fields) |
There was a problem hiding this comment.
Check returned value is 1. Given that we have id based lookup.
There was a problem hiding this comment.
Maybe we should have each transition as its own specific method, since they look like they have transition-specific logic, like that if "now" in transition info. It might be easier to maintain and customize transitions that look like
class JobExecution:
...
def transition_to_running(self):
update_time = datetime.datetime.utcnow()
num_records = self.filter(status=JobStatus.created).update(status=JobStatus.running, started_on=update_time)
if num_records != 1:
raise SomeException(...)There was a problem hiding this comment.
Maybe we should have each transition as its own specific method, since they look like they have transition-specific logic, like that
if "now" in transition info
I don't see any value for this right now because the transition-specific logic is minimal. Also, transitions are driven by a status value anyway.
emilmelnikov
force-pushed
the
job-stats
branch
from
dcad600
to
77d5c1b
Compare
* Add "started_on" and "finished_on" fields to the Job model. * Add the "Running Time" column to the project job list view. Other changes: * Remove the row number field from the project job list view: job ID should be sufficient for debugging. * Add full job ID tooltip. * Change submission time tooltip from short human-readable format to full date string in order to provide more information.
Closes #55.
emilmelnikov
force-pushed
the
job-stats
branch
from
77d5c1b
to
c6d9ee0
Compare
Other changes:
job ID should be sufficient for debugging.
to full date string in order to provide more information.
Closes #44.