-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Octave compatibility with ImageJ-Matlab #8
Comments
@hinerm Any guesses? I noticed that @ericbarnhill has now filed fiji-BIG/mij#1 to make MIJ Octave-compatible. But I would much rather fix the issue here in ImageJ-MATLAB. I am very uncomfortable with the legal status of MIJ and would like to retire and/or move it out of Fiji. |
I have had some additional problems in Octave 4.3 too, that I was going to try to patch myself. If legal status is a problem why not just fork the project and call it Octave-ImageJ since it works there now. Then in the next couple of months I could test and see what is working and what is not, add functionality to get images back into Octave, etc. |
I'm guessing too much of the MATLAB framework is being reused and the service is opening a proxy connection to MATLAB. Here is where the MATLAB instance is created. So you can see in the MatlabBindings it communicates with the proxy to exchange data with the MATLAB instance. You'll need to add your own bindings so that it's communicating with Octave instead. |
@ericbarnhill wrote:
The license of MIJ does not allow us to do that. Actually, the repository https://github.com/fiji/mij is already a legally murky fork of the code from http://bigwww.epfl.ch/sage/soft/mij/. The BIG license states:
Fiji has legal permission to redistribute BIG components. But this does not cover modifications, and the components are still not redistributable by anyone else. Sorry to belabor the legal point in this issue, when it is only tangentially related. But I just want to explain why we created the @hinerm wrote:
Mark, do you see a nice way we could generalize this component to allow for either MATLAB or Octave? Or failing that, at least a key place where we could add hardcoded case logic? |
I think that would do it. I'm probably forgetting a few things though! |
@hinerm Thanks for thinking it through. Somehow I doubt anyone in the community is going to pursue this work, given how involved it is, but one can always hope... |
For what it's worth, I did finally merge fiji-BIG/mij#1 (though see the caveats written there). I also added a link to this issue from the Wish list page of the ImageJ wiki. |
Hi, I made some progress getting ImageJ-Matlab to run in Octave, and my version now opens in Octave...
The one problem is, when ImageJ is launched in Octave, it then launches its own instance of Matlab! (I have both programs). Can anyone advise where this launch of Matlab might be coming from, and if so I can take a look and see if this can be made compatible with being called from an Octave instance? Thanks!
The text was updated successfully, but these errors were encountered: