Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New SD/MMC driver fails to read blocks from the SD card #9

Open
valpackett opened this issue Mar 7, 2019 · 3 comments
Open

New SD/MMC driver fails to read blocks from the SD card #9

valpackett opened this issue Mar 7, 2019 · 3 comments
Assignees
@imbushuo
Labels
area-sdhci bug Something isn't working

Comments

@valpackett
Copy link

EFI Shell is displayed instead of bootaa64.efi from the SD card. GPT partitions show up in the EFI Shell.

Replacing the shell with FreeBSD boot1.efi shows "Failed Reading block" errors:

photo

The card is this:

mmcsd0: 16GB <SDHC SL16G 8.0 SN 92C00EE4 MFG 06/2015 by 3 SD> at mmc0 48.0MHz/4bit/65535-block
@imbushuo imbushuo added area-sdhci bug Something isn't working help wanted Extra attention is needed labels Mar 8, 2019
@imbushuo imbushuo self-assigned this Mar 8, 2019
@imbushuo
Copy link
Owner

imbushuo commented Mar 8, 2019

@myfreeweb In

NintendoSwitchPkg/Drivers/SdMmcDxe/EfiBlkDeviceOp.c

Line 86 in da0dd9a

UINT32 read_size = 512 * 128;

Can you try to modify 128 to some smaller value to see if situation improves?

1 will absolutely work, but probably too slow. This value shall be adaptive and I think SDMMC1 auto calibration is necessary to be added later.

@valpackett
Copy link
Author

thanks! 32 works

imbushuo added a commit that referenced this issue Mar 8, 2019
@imbushuo
SDMMC: Lower batch block read size to 64 to mitigate #9.
12c859f 
Need more intensive testing. Also added auto recovery (though it may not work).
@imbushuo imbushuo removed the help wanted Extra attention is needed label Mar 10, 2019
@Owen-sys
Copy link

Owen-sys commented Jul 7, 2020

does this fully work on switch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imbushuo imbushuo

Labels
area-sdhci bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@valpackett @imbushuo @Owen-sys