Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch in glib in AppImage #14

Closed

Conversation

rithvikvibhu
Copy link
Collaborator

Closes #9, Closes #12.

Around 4 months ago, this PR was merged into glib2 and then released in version 2.69.1.

This PR:

I've tested this on Manjaro / Arch. Would be great if someone can test it on Ubuntu before merging.

@JustYourAverageGithubUser

appimage works on arch based Linux distros with this fix.

@buffrr
Copy link
Member

buffrr commented Mar 4, 2022

Would be great if someone can test it on Ubuntu before merging.

Thanks for the PR! There seems to be an issue on Ubuntu 20. I get this error when opening the AppImage:

./Fingertip.AppImage: error while loading shared libraries: libffi.so.8: cannot open shared object file: No such file or directory

old AppImage works with the same setup/Ubuntu verison.

@rithvikvibhu
Copy link
Collaborator Author

Sheesh this whole PR's a bit embarrassing, didn't test in other distros and is also hacky >.<

Feel free to close this and rewrite it if needed.

@buffrr
Copy link
Member

buffrr commented Mar 4, 2022

Sheesh this whole PR's a bit embarrassing, didn't test in other distros and is also hacky >.<

Haha no worries linux is a bit of a pain to package for with a 100 different distros requiring different things.

Feel free to close this and rewrite it if needed.

Don't have the bandwidth to deal with this right now. It may be something simple ;) I'll revisit later if no one has worked on it.

@rithvikvibhu
Copy link
Collaborator Author

I don't know what has changed recently, but without this PR, the CI build works on Ubuntu 18.04, 22.10, and manjaro/arch (rolling). So closing this as no longer required.

The build tried: https://github.com/imperviousinc/fingertip/actions/runs/4220153228 which is #32

ubuntu 18.04 (glibc 2.27):

image

ubuntu 22.10 (glibc 2.36):

image
(libfuse2 is no longer installed by default on ubuntu 22.04+ and needs sudo apt install libfuse2) so after this:
image

manjaro (glibc 2.37):

(ignoring the warnings, it works)
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not Working on Arch Linux symbol lookup error
3 participants