Added PLL7 (USB2 PLL) Support #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PLL7 is required to use the secondary USB controller. PLL3 is only used for the primary USB controller. I briefly read through the imxrt1060 specification to ensure that it was intended to be clocked identically. I can't imagine much else needs verification, as this addition seems relatively simple.
|
PLL7 doesn't exist on the smaller i.MX RT MCUs, like the 1010 and 1020. That's why CI is failing. Consider exporting PLL7 only when building for the 1060 MCUs. It might look similar to how we include and export PLL1 when building for the 1060. |
This reverts commit a18cda8.
|
My mistake. Thanks for the pointers. Hopefully it's a bit better now. |
mciantyre
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLL7 is required to use the secondary USB controller. PLL3 is only used for the primary USB controller.
I briefly read through the i.MX RT1060 specification and noticed no meaningful differences between the USB1 and USB2 PLLs. Assuming I haven't overseen anything, PLL7 should have an identical implementation as PLL3, with the only variation being the USB controller number in the register names.