Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ID generic is not really used #2

Open
sherzinger opened this issue Nov 21, 2019 · 0 comments
Open

The ID generic is not really used #2

sherzinger opened this issue Nov 21, 2019 · 0 comments

Comments

@sherzinger
Copy link
Member

https://github.com/in-cal/incal-access-elastic/blob/master/src/main/scala/org/incal/access/elastic/ElasticAsyncReadonlyRepo.scala#L60

At this point you say "I don't care care what type ID is." You might as well remove this generic and just use String as a type instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant