-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing sequences with manual overlap #47
Comments
Could you please apply this patch and re-make trimal to see if it works as expected? HOW-TO Patch: patch_issue#47.txt |
@scapella and I have been discussing the behaviour of this method, and it seems it works as expected, sorry for my misunderstanding on the last message. And thanks @scapella for the clarification here. Let me explain what it is used for: Overlap is defined as having a gap in both positions, an indetermination in both positions, or a residue in both positions. It may be clearer with an example:
In this case, Sp8 may be removed, depending on the thresholds, as it contains:
So, what residue is on the position is not relevant for this trimming method, as it is focused to check whether the two sequences compared contain:
and compares pair by pair of sequences to obtain a score for each sequence. So, when you change the gaps by 'T' on your alignment, the score for the sequence is higher and thus, not removed from the alignment. This is the desired behaviour |
Hi, |
The option to remove sequences using -seqoverlap and -resoverlap produces results I find unexpected. From what I can tell, it seems that when -resoverlap compares if a residue is the same in the other sequences it does not consider the base identity (for a DNA alignment), only whether there is a gap character or any DNA base. Therefore, for a gapfree alignment, if I change all bases in a sequence to e.g. "T" the sequence will not be removed from the alignment, even with strict settings, (e.g. -resoverlap 0.9 seqoverlap 95).
Is this how it is supposed to work and if so I'm curious why it works like this and not as I might have expected it to? Thanks
The text was updated successfully, but these errors were encountered: