Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow env variable string substitution in rewrite rules #39

Open
matin-nayob opened this issue Jul 10, 2024 · 0 comments
Open

Allow env variable string substitution in rewrite rules #39

matin-nayob opened this issue Jul 10, 2024 · 0 comments

Comments

@matin-nayob
Copy link

Firstly, thank you for this project, it really is awesome!

We have multiple isolated K8s clusters, with separate Harbor instances in each one, accessible on different domains.

It would be super neat if the rules config allowed you to substitute parts of the replace section with an environment variable value, like:

replace: '${HARBOR_DOMAIN}/dockerhub-proxy

As we use kustomize with helm to generate the final k8s manifests for this project, we end up repeating the values.yaml file for each cluster with only the harbor domain being different in each file.

Not a big deal, but if you think its a good ideal, thats cool.

Once again, thank you for this project, it really has made switching to Harbor so much easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant