Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make threshold_rho an argument, select t=0 #201

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

k-collie
Copy link
Collaborator

Fixes #200

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (88de226) 88.73% compared to head (0014dd2) 88.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
+ Coverage   88.73%   88.78%   +0.04%     
==========================================
  Files          43       43              
  Lines        4422     4422              
==========================================
+ Hits         3924     3926       +2     
+ Misses        498      496       -2     
Impacted Files Coverage Δ
indica/operators/extrapolate_impurity_density.py 93.60% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@k-collie k-collie force-pushed the k-collie/200_optimize_perturbation_bugs branch from 363ab66 to 41a03aa Compare March 22, 2023 13:00
@k-collie k-collie force-pushed the k-collie/200_optimize_perturbation_bugs branch from 41a03aa to 0014dd2 Compare June 28, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimise perturbation should take threshold_rho, should select 0 time point for initial guess
1 participant