Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow atomic_data to take multi-dimensional profiles #205

Open
k-collie opened this issue Nov 22, 2022 · 1 comment
Open

Allow atomic_data to take multi-dimensional profiles #205

k-collie opened this issue Nov 22, 2022 · 1 comment
Labels
calculations Calculating new quantities from existing ones enhancement New feature or request

Comments

@k-collie
Copy link
Collaborator

Currently the functions in atomic_data can only handle 1-D profiles (usually rho). It would be useful if it could handle multiple dimensions (notably time), to avoid the following style concatenations:

    elem: xr.concat(
        [
            FA[elem](
                Ne=ne.interp(t=time),
                Te=te.interp(t=time),
                tau=time,
            ).expand_dims("t", -1)
            for time in t.values
        ],
        dim="t",
    )
    .assign_coords({"t": t.values})
    .assign_attrs(transform=flux_surface)
@k-collie k-collie added enhancement New feature or request calculations Calculating new quantities from existing ones labels Nov 22, 2022
@k-collie
Copy link
Collaborator Author

Alternatively, since FA only depends on Ne and Te which are both 1D on rho, use 1D profile to calculate and then interpolate onto 2D profile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
calculations Calculating new quantities from existing ones enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant