Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

friends' messages are not being highlighted #23

Open
bretonium opened this issue Feb 25, 2022 · 1 comment
Open

friends' messages are not being highlighted #23

bretonium opened this issue Feb 25, 2022 · 1 comment

Comments

@bretonium
Copy link

Steps to reproduce:

  1. Add someone to friends
    • this can be done, for example, via the "friends" tab in the lower-right part of the screen by typing their name
    • or by clicking on the player in the "info" tab in the player list
    • or via the add_friend command in the console
  2. Get the friend to write something in the chat

Expected: the friend's messages is highlighted
Observed: the friend's message is not highlighted unless they are in the spectators

Screenshot_20220225_120706

The issue is not exclusive to infclass-client, ddnet and teeworlds clients also suffer from this. But infclass-client looks like an easy place to start fixing it. I think the issue happens because the class of players is communicated via the "Clan" field, and it seems to be participating in the friend-matching.

The issue affects not only highlighting of the messages; it also affects the "Only show chat messages from friends" option in the client, rendering it useless.

@bretonium
Copy link
Author

turns out, there is cl_friends_ignore_clan option, and it is set to 0 for me in settings_ddnet.cfg. I do not remember setting it, and cannot find a corresponding checkbox for it in the ui. Welp, the problem is solved for me. Maybe infclass-client could expose this option in the ui.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant