Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Rewriting question should consider chat history #2484

Closed
1 task done
Defozo opened this issue Sep 19, 2024 · 0 comments
Closed
1 task done

[Feature Request]: Rewriting question should consider chat history #2484

Defozo opened this issue Sep 19, 2024 · 0 comments
Labels

Comments

@Defozo
Copy link
Contributor

Defozo commented Sep 19, 2024

Is there an existing issue for the same feature request?

  • I have checked the existing issues.

Is your feature request related to a problem?

Example:
Firstly, a user asks about Michael Jackson and receives an answer.
Secondly, a user asks "When was he born?" and doesn't receive an answer because chat history is taken into account only in the last step - when LLM is generating an answer. The workflow exceeds maximum question rewrites as the retrieval doesn't return anything for "When was he born?".

Describe the feature you'd like

I believe question rewrite should take into account chat history so that the question "When was he born?" can be rewritten as "When was Michael Jackson born?".

@KevinHuSh KevinHuSh mentioned this issue Sep 20, 2024
49 tasks
KevinHuSh added a commit that referenced this issue Sep 20, 2024
### What problem does this PR solve?

#2362 #2484

### Type of change

- [x] New Feature (non-breaking change which adds functionality)
- [x] Performance Improvement
KevinHuSh added a commit that referenced this issue Sep 24, 2024
### What problem does this PR solve?

#2484

### Type of change

- [x] Performance Improvement
- [ ] Other (please describe):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants