Featured content blocks contains logic that should be located in a filter

[dingo-d]

eightshift-frontend-libs/blocks/init/src/Blocks/custom/featured-content/featured-content.php

Lines 29 to 94 in 64a5c3e

	global $post;
	$args = [
	'post_type' => $featuredContentPostType,
	'posts_per_page' => $featuredContentLayoutTotalItems,
	'fields' => 'ids',
	'order' => 'ASC',
	];
	if ($featuredContentTaxonomy) {
	$args['tax_query'][0] = [
	'taxonomy' => $featuredContentTaxonomy,
	'field' => 'id',
	];
	if ($featuredContentTerms) {
	$args['tax_query'][0]['terms'] = array_map(
	function ($item) {
	return $item['value'];
	},
	(array)$featuredContentTerms
	);
	} elseif ($featuredContentUseCurrentTerm && $post instanceof WP_Post && !$featuredContentServerSideRender) {
	$currentTerms = get_the_terms($post->ID, strval($featuredContentTaxonomy));
	if ($currentTerms) {
	$args['tax_query'][0]['terms'] = [$currentTerms[0]->term_id]; // @phpstan-ignore-line
	}
	} else {
	$args['tax_query'][0]['operator'] = 'NOT IN'; // phpcs:ignore WordPress.DB.SlowDBQuery.slow_db_query_tax_query
	}
	}
	$excludeList = [];
	if ($featuredContentExcludeCurrentPost && $post instanceof WP_Post) {
	$excludeList[] = $post->ID;
	}
	if ($excludeList) {
	$args['post__not_in'] = $excludeList;
	}
	if ($featuredContentPosts) {
	$args['post__in'] = array_map(
	function ($item) {
	return $item['value'];
	},
	(array)$featuredContentPosts
	);
	$args['orderby'] = 'post__in';
	}
	if ($featuredContentRandomOrder) {
	$args['orderby'] = 'rand';
	}
	$mainQuery = new WP_Query($args);
	if (!$mainQuery->have_posts()) {
	return;
	}
	wp_reset_postdata();

I understand that this is done in a way it is because you have a standalone block that works, but this should be refactored to use a filter that will return, cache, .etc, the data...

Currently, it mixes presentational and business logic.