Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: updates service accept header to application/json #733

Merged
merged 16 commits into from
Jul 19, 2024
Merged

feat: updates service accept header to application/json #733

merged 16 commits into from
Jul 19, 2024

Conversation

karel-rehor
Copy link
Contributor

@karel-rehor karel-rehor commented Jun 20, 2024 •
edited by bednar
Loading

Closes #719
Closes #744

Proposed Changes

  • changes Accept header in InfluxQLQueryService to application/json
  • adds deserializers for json results
  • adds tests

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@karel-rehor karel-rehor requested a review from bednar June 20, 2024 15:26
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 87.85047% with 13 lines in your changes missing coverage. Please review.

Project coverage is 88.51%. Comparing base (546197d) to head (92295f9).
Report is 10 commits behind head on master.

Files Patch % Lines
...influxdb/client/internal/InfluxQLQueryApiImpl.java 91.56% 4 Missing and 3 partials ⚠️
...n/java/com/influxdb/internal/AbstractQueryApi.java 28.57% 4 Missing and 1 partial ⚠️
...java/com/influxdb/client/domain/InfluxQLQuery.java 94.11% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #733      +/-   ##
============================================
+ Coverage     88.37%   88.51%   +0.14%     
+ Complexity      786      784       -2     
============================================
  Files           174      174              
  Lines          7091     7195     +104     
  Branches        391      405      +14     
============================================
+ Hits           6267     6369     +102     
+ Misses          698      696       -2     
- Partials        126      130       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bednar bednar mentioned this pull request Jul 8, 2024
Closed
bednar
bednar requested changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address also issue from #744.

@karel-rehor karel-rehor marked this pull request as ready for review July 15, 2024 14:47
@karel-rehor karel-rehor requested a review from bednar July 15, 2024 14:47
bednar
bednar requested changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! 👍 Before we can proceed with accepting it, there are a few requirements that need to be met:

client/src/main/java/com/influxdb/client/internal/InfluxQLQueryApiImpl.java Show resolved Hide resolved
bednar
bednar approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your PR 👍

LGTM 🚀

@karel-rehor karel-rehor merged commit 7b39e0c into master Jul 19, 2024
12 checks passed
@karel-rehor karel-rehor deleted the fix/enhance719 branch July 19, 2024 14:14
@bednar bednar added this to the 7.2.0 milestone Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bednar bednar bednar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.2.0
3 participants
@karel-rehor @codecov-commenter @bednar