chore: add test for mapping to sinker container #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebond
force-pushed
the
chore/to-sinkercontainer-test
branch
from
fcd3027
to
c40045c
Compare
philjb
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #54 as not a bug.
a no-op, just a test.
i was seeing an issue in one of our clusters that led me to create #54 so i wrote a test to reproduce it. this test is the scenario that i'm seeing but it works, so i guess i'm mistaken and will go investigate there.
good to have a test to cover this case anyway.
also driveby no-op test fix of group name.