Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update vwo smartcode #6750

Merged
merged 1 commit into from
Jul 5, 2023
Merged

chore: update vwo smartcode #6750

merged 1 commit into from
Jul 5, 2023

Conversation

mavarius
Copy link
Collaborator

@mavarius mavarius commented Jun 29, 2023

Addresses https://github.com/influxdata/idpe/issues/16543

This PR updates the version of the VWO smartcode to v1.5

Checklist

Authors and Reviewer(s), please verify the following:

@mavarius mavarius requested a review from a team as a code owner June 29, 2023 20:32
@wdoconnell
Copy link
Contributor

@mavarius Is this needed to take advantage of new VWO features?

@mavarius
Copy link
Collaborator Author

@mavarius Is this needed to take advantage of new VWO features?

No, this is to address the security vulnerability outlined in https://github.com/influxdata/idpe/issues/16543.

@wdoconnell
Copy link
Contributor

@mavarius Thanks - has VWO updated the code on their end to ensure it isn't using the deprecated jquery version?

@wdoconnell
Copy link
Contributor

wdoconnell commented Jun 29, 2023

The critical thing here is ensuring that our patch to resolve the "black screen of death" issue still works - namely that in src/App.tsx, we are still removing the correct style as a fallback in the event that the VWO script fails like it did a couple months ago. It looks like to be same style name (_vis_opt_path_hides), which is good. I don't love having to use third-party code like this that is already difficult to understand, but I get why we need to given the IDPE issue.

If we run into issues with the upgraded script, the first line of defense is to flip the flag vwoAbTesting off in ConfigCat to troubleshoot any issues with the script.

@mavarius
Copy link
Collaborator Author

@wdoconnell I noticed that these two rules were removed in the previous implementation, so I removed them here again. Maybe they were part of what caused the black screen issue last time.

hide_element='body',
hide_element_style = 'opacity:0 !important;filter:alpha(opacity=0) !important;background:none !important',

@mavarius mavarius added this pull request to the merge queue Jul 5, 2023
Merged via the queue into master with commit e7bb199 Jul 5, 2023
3 checks passed
@mavarius mavarius deleted the chore/upgrade-vwo branch July 5, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants