-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): python onboarding updating to influxdb3 python #6770
feat(ui): python onboarding updating to influxdb3 python #6770
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mavarius Good work! 👍 I trust you on all the codeSnippet since I don't have the context for the content of the tutorial. Everything else in code looks good to me except one bug:
Seems like there is a bug on the step 7 "Execute an Aggregate Query" when the feature flag ioxOnboarding
is set to true. See video below:
Screen.Recording.2023-07-21.at.4.55.48.PM.mov
<WriteDataDetailsContextProvider> | ||
{this.renderStep()} | ||
{isFlagEnabled('ioxOnboarding') | ||
? this.renderSqlStep() | ||
: this.renderStep()} | ||
</WriteDataDetailsContextProvider> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! This flow is cleaner than before 👍
You have to refresh the page if you switch the flag. The Serverless version of the Java instructions doesn't have the aggregate step at all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mavarius My bad! I was looking at the Java onboarding flow instead of the Python onboarding flow 🤦♀️ I double checked and everything flows nicely on my local machine. Approving now. Sorry for the delay!
Closes #6761
This PR updates the Python onboarding with the new client library and adds InfluxQL aggregation instructions.
Checklist
Authors and Reviewer(s), please verify the following: