Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): python onboarding updating to influxdb3 python #6770

Merged
merged 3 commits into from
Jul 28, 2023

Conversation

mavarius
Copy link
Collaborator

@mavarius mavarius commented Jul 20, 2023

Closes #6761

This PR updates the Python onboarding with the new client library and adds InfluxQL aggregation instructions.

Checklist

Authors and Reviewer(s), please verify the following:

  • A PR description, regardless of the triviality of this change, that communicates the value of this PR
  • Well-formatted conventional commit messages that provide context into the change
  • Documentation updated or issue created (provide link to issue/PR)

@mavarius mavarius requested a review from a team as a code owner July 20, 2023 18:09
@mavarius mavarius linked an issue Jul 20, 2023 that may be closed by this pull request
@mavarius mavarius changed the title 6761 python onboarding updating to influxdb3 python feat(ui): python onboarding updating to influxdb3 python Jul 20, 2023
Copy link
Contributor

@appletreeisyellow appletreeisyellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mavarius Good work! 👍 I trust you on all the codeSnippet since I don't have the context for the content of the tutorial. Everything else in code looks good to me except one bug:

Seems like there is a bug on the step 7 "Execute an Aggregate Query" when the feature flag ioxOnboarding is set to true. See video below:

Screen.Recording.2023-07-21.at.4.55.48.PM.mov

Comment on lines 264 to 268
<WriteDataDetailsContextProvider>
{this.renderStep()}
{isFlagEnabled('ioxOnboarding')
? this.renderSqlStep()
: this.renderStep()}
</WriteDataDetailsContextProvider>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This flow is cleaner than before 👍

@mavarius
Copy link
Collaborator Author

@appletreeisyellow

You have to refresh the page if you switch the flag. The Serverless version of the Java instructions doesn't have the aggregate step at all.

image

Copy link
Contributor

@appletreeisyellow appletreeisyellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mavarius My bad! I was looking at the Java onboarding flow instead of the Python onboarding flow 🤦‍♀️ I double checked and everything flows nicely on my local machine. Approving now. Sorry for the delay!

@mavarius mavarius added this pull request to the merge queue Jul 27, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 27, 2023
@mavarius mavarius added this pull request to the merge queue Jul 27, 2023
Merged via the queue into master with commit e195ae9 Jul 28, 2023
4 of 5 checks passed
@mavarius mavarius deleted the 6761-python-onboarding-updating-to-influxdb3-python branch July 28, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python onboarding - Updating to influxdb3-python
2 participants