Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Great Testing Refactor #131

Open
qpfiffer opened this issue Oct 7, 2014 · 4 comments
Open

The Great Testing Refactor #131

qpfiffer opened this issue Oct 7, 2014 · 4 comments

Comments

@qpfiffer
Copy link
Member

qpfiffer commented Oct 7, 2014

Tests need to be split up. We need tests for the frontend. This ticket is for:

  • Where do we put tests?
  • The testing binary needs to have everything split up logically to test components
  • Where do the frontend tests live and what do we write them in?
@Hamcha
Copy link
Member

Hamcha commented Oct 7, 2014

Related to #126
I still want duration in tests if possible, it'll make it easier to find bottlenecks without bothering the buildbot.

My proposal is to still make them a different folder, although a Golang-style "<something>_test.[c|h]" (as @kyleterry proposed on IRC) might be cool, although I fear cluttering of the source/include folder.

As currently decided with @kyleterry, Frontend tests will come in two flavors: binding tests (via go test) and api tests (via shell→curl).
We're using #127 for the details on those.

@colby
Copy link
Contributor

colby commented Oct 7, 2014

I personally would like to see tests in project root, under test/ or spec/, from there perhaps it could be test/frontend/testserver.c and/or spec/backend/findkey.c, roughly.

I am not familiar with C or Go testing, only Ruby, which would be useless to pull in for testing.

@Hamcha
Copy link
Member

Hamcha commented Oct 9, 2014

I like the test subfolder idea!

@kyleterry
Copy link
Member

Me too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants