Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction Optimizations #135

Open
qpfiffer opened this issue Nov 27, 2014 · 2 comments
Open

Transaction Optimizations #135

qpfiffer opened this issue Nov 27, 2014 · 2 comments
Assignees

Comments

@qpfiffer
Copy link
Member

Idle thoughts on ways to improve the transaction implementation:

  • dirty state: if a transaction didn't actually do anything (quite common for ol_unjar operations) then we should just discard the transaction when we're done instead of writing back an empty AOL file. Done.
  • Don't read the transaction's AOL file from disk: This is probably the slowest part of the whole procedure. I did it in a really dumb way. The transaction is written to disk, and then read back in from disk during commit.
@qpfiffer qpfiffer self-assigned this Nov 27, 2014
@Hamcha
Copy link
Member

Hamcha commented Nov 27, 2014

Keeping all them in memory at all time isn't the best either, can't we have either a timeout or a "when I'm holding more than X transactions I'll put N oldest away" thing?

@qpfiffer
Copy link
Member Author

@Hamcha Wow I guess I never saw your comment, but yeah with the current architecture we should be able to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants