Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return top-k candidates for ED? #77

Open
AVBelyy opened this issue Apr 22, 2021 · 3 comments
Open

Return top-k candidates for ED? #77

AVBelyy opened this issue Apr 22, 2021 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@AVBelyy
Copy link

AVBelyy commented Apr 22, 2021

Hi,

Is it possible to return top-k most likely candidates for the disambiguation step? This would help in my application: when the top-1 predicted entity is incorrect, we give users a chance to correct that.

Thanks!

@mickvanhulst mickvanhulst added enhancement New feature or request good first issue Good for newcomers labels Apr 22, 2021
@mickvanhulst
Copy link
Collaborator

mickvanhulst commented Apr 22, 2021

Hi,

At the moment this is not implemented, but it should not be too much work. If you use our API, you can see in our server file (code) that we are using a function called process_results (code). This function receives our predictions. Our predictions dictionary should include both candidates and scores as a key respectively. Although we currently don't return them, it should only take a few lines of changes in the process_results function to get the top-k predictions that you want.

If you have the time to work on this, it would be great if you could file a PR as I can imagine that this is a useful feature for many applications :)!

@aflah02
Copy link

aflah02 commented Mar 11, 2023

@mickvanhulst Is this still open? I have some free time on hand to take a look!

@KDercksen
Copy link
Contributor

@aflah02 it is still TBD! It would be great if you can take a look :) See also here for the dictionary keys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants